Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use interfaces module as Path instead of Ident #213

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Aug 3, 2023

closes #212

@jawoznia jawoznia requested a review from hashedone August 3, 2023 13:57
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #213 (596f682) into main (ec8b947) will increase coverage by 0.93%.
The diff coverage is 98.83%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   86.78%   87.72%   +0.93%     
==========================================
  Files          24       24              
  Lines        1241     1238       -3     
==========================================
+ Hits         1077     1086       +9     
+ Misses        164      152      -12     
Files Changed Coverage Δ
sylvia/tests/querier.rs 96.55% <ø> (ø)
sylvia-derive/src/interfaces.rs 94.93% <98.33%> (+8.57%) ⬆️
sylvia-derive/src/input.rs 94.11% <100.00%> (+0.52%) ⬆️
sylvia-derive/src/message.rs 83.37% <100.00%> (-0.22%) ⬇️
sylvia-derive/src/multitest.rs 93.03% <100.00%> (+1.73%) ⬆️
sylvia-derive/src/remote.rs 100.00% <100.00%> (+8.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requests. It needs to be a proper usage of Deref. Also, we cannot ignore errors - if we cannot ensure information is ensured by types, we must assume it might be invalid. If you want to eliminate some error handling with asserts, you must figure out better types.

sylvia-derive/src/interfaces.rs Outdated Show resolved Hide resolved
sylvia-derive/src/interfaces.rs Outdated Show resolved Hide resolved
sylvia-derive/src/message.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit 482bc7b into main Aug 14, 2023
7 checks passed
@jawoznia jawoznia deleted the fix_proxy_accessors branch August 14, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Methods in multitest proxy are generated using interfaces module as Ident instead of Path
2 participants