Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast deps to empty #214

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Cast deps to empty #214

merged 4 commits into from
Sep 5, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Aug 10, 2023 •
edited
Loading

closes #201

@jawoznia jawoznia changed the base branch from main to custom_queries August 10, 2023 14:41
@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Merging #214 (eb70379) into custom_queries (5e17605) will decrease coverage by 0.25%.
The diff coverage is 83.33%.

@@                Coverage Diff                 @@
##           custom_queries     #214      +/-   ##
==================================================
- Coverage           88.02%   87.78%   -0.25%     
==================================================
  Files                  25       24       -1     
  Lines                1278     1302      +24     
==================================================
+ Hits                 1125     1143      +18     
- Misses                153      159       +6
Files Changed Coverage Δ
sylvia/tests/custom_msg.rs 100.00% <ø> (ø)
sylvia-derive/src/parser.rs 84.53% <77.77%> (-0.70%) ⬇️
sylvia/tests/custom_query.rs 92.00% <80.00%> (-3.00%) ⬇️
sylvia-derive/src/message.rs 83.73% <92.30%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia marked this pull request as ready for review August 23, 2023 12:45
hashedone
hashedone reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation seems correct, but the critical test is missing.

Also, one styling comment - you decide if you want to follow it.

sylvia-derive/src/message.rs Outdated Show resolved Hide resolved
sylvia-derive/src/parser.rs Outdated Show resolved Hide resolved
sylvia/tests/custom_query.rs Show resolved Hide resolved
hashedone
hashedone approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit a0c6131 into custom_queries Sep 5, 2023
5 of 7 checks passed
@jawoznia jawoznia deleted the cast_deps_to_empty branch September 5, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @hashedone