chore: Remove MessageSignature from multitest
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawoznia
force-pushed
the
remove_message_signature
branch
from
3b28694
to
7b4ae63
Compare
Codecov Report
@@ Coverage Diff @@
## feat/generics_support #241 +/- ##
=========================================================
+ Coverage 87.83% 88.68% +0.84%
=========================================================
Files 25 25
Lines 1595 1670 +75
=========================================================
+ Hits 1401 1481 +80
+ Misses 194 189 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jawoznia
force-pushed
the
simple_generic_contract
branch
from
a91b3e7
to
d0edd45
Compare
jawoznia
force-pushed
the
remove_message_signature
branch
from
7b4ae63
to
4435a57
Compare
|
What is this change purpose? |
jawoznia
force-pushed
the
simple_generic_contract
branch
from
d0edd45
to
2badc3a
Compare
Base automatically changed from
simple_generic_contract
to
feat/generics_support
October 19, 2023 14:09
This change is not connected directly to the feature but I found it troublesome at some points to work with the original design. I decided to smuggle this small refactor in this feature to ease the further development and to rely on it in future refactor. Before merge to main I will squash this commit to not pollute commit history with |
jawoznia
force-pushed
the
remove_message_signature
branch
from
4435a57
to
595cf2b
Compare
hashedone
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.