Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support generic exec #242

Merged

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #242 (4742385) into feat/generics_support (3d78b45) will decrease coverage by 1.93%.
Report is 3 commits behind head on feat/generics_support.
The diff coverage is 95.19%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #242      +/-   ##
=========================================================
- Coverage                  87.83%   85.91%   -1.93%     
=========================================================
  Files                         25       24       -1     
  Lines                       1595     1654      +59     
=========================================================
+ Hits                        1401     1421      +20     
- Misses                       194      233      +39     
Files Coverage Δ
sylvia-derive/src/input.rs 92.98% <100.00%> (-2.26%) ⬇️
sylvia-derive/src/interfaces.rs 87.87% <100.00%> (-2.78%) ⬇️
sylvia-derive/src/multitest.rs 96.29% <100.00%> (+2.12%) ⬆️
sylvia/src/types.rs 80.00% <ø> (ø)
sylvia-derive/src/parser.rs 81.64% <87.50%> (-1.05%) ⬇️
sylvia-derive/src/message.rs 82.73% <93.46%> (-0.84%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the contract_supports_every_generic_message branch from 6314ecd to bec1a37 Compare October 20, 2023 18:41
@jawoznia jawoznia marked this pull request as ready for review October 20, 2023 18:41
@jawoznia jawoznia force-pushed the contract_supports_every_generic_message branch from bec1a37 to 9279be0 Compare October 20, 2023 18:48
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me with one relevant comment - I thnk it still can be a CT check with a minimal change.

sylvia-derive/src/input.rs Show resolved Hide resolved
sylvia-derive/src/message.rs Outdated Show resolved Hide resolved
Base automatically changed from remove_message_signature to feat/generics_support October 23, 2023 09:31
@jawoznia jawoznia force-pushed the contract_supports_every_generic_message branch 2 times, most recently from cb9adf2 to dfa4f54 Compare October 23, 2023 11:53
@jawoznia jawoznia merged commit cf2c26d into feat/generics_support Oct 25, 2023
6 of 7 checks passed
@jawoznia jawoznia deleted the contract_supports_every_generic_message branch October 25, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants