Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Wrap contract types in sv module #247

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: Wrap contract types in sv module #247

merged 1 commit into from
Oct 30, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Oct 25, 2023 •
edited
Loading

close #114

@jawoznia jawoznia force-pushed the generate_contract_types_in_sv_module branch from 00b5f95 to 8f840c3 Compare October 25, 2023 17:29
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #247 (25500b7) into feat/generics_support (88ca546) will not change coverage.
The diff coverage is 94.73%.

@@                  Coverage Diff                   @@
##           feat/generics_support     #247   +/-   ##
======================================================
  Coverage                  85.87%   85.87%           
======================================================
  Files                         24       24           
  Lines                       1657     1657           
======================================================
  Hits                        1423     1423           
  Misses                       234      234
Files Coverage Δ
sylvia-derive/src/input.rs 93.10% <ø> (ø)
sylvia/tests/custom_msg.rs 100.00% <ø> (ø)
sylvia/tests/custom_query.rs 92.00% <ø> (ø)
sylvia/tests/dispatching.rs 93.33% <100.00%> (ø)
sylvia/tests/entry_points.rs 100.00% <ø> (ø)
sylvia/tests/messages_generation.rs 0.00% <ø> (ø)
sylvia/tests/querier.rs 96.66% <100.00%> (ø)
sylvia/tests/query_returns.rs 0.00% <ø> (ø)
sylvia/tests/remote.rs 0.00% <ø> (ø)
sylvia-derive/src/message.rs 82.73% <66.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hashedone
hashedone approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia force-pushed the generate_impl_types_in_sv_module branch from ba0fe74 to d6385b0 Compare October 27, 2023 18:54
Base automatically changed from generate_impl_types_in_sv_module to feat/generics_support October 30, 2023 10:37
@jawoznia jawoznia force-pushed the generate_contract_types_in_sv_module branch from 8f840c3 to 25500b7 Compare October 30, 2023 10:39
@jawoznia jawoznia merged commit 9d44792 into feat/generics_support Oct 30, 2023
7 checks passed
@jawoznia jawoznia deleted the generate_contract_types_in_sv_module branch October 30, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

@DariuszDepta DariuszDepta Awaiting requested review from DariuszDepta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @hashedone