Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expect , in :custom(msg, query) #250

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: Expect , in :custom(msg, query) #250

merged 1 commit into from
Nov 7, 2023

Conversation

jawoznia
Copy link
Collaborator

This check was missed in tests. Found it while updating the sylvia book.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #250 (a918239) into main (cb15d56) will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   87.72%   87.74%   +0.02%     
==========================================
  Files          24       24              
  Lines        1303     1306       +3     
==========================================
+ Hits         1143     1146       +3     
  Misses        160      160              
Files Coverage Δ
sylvia-derive/src/parser.rs 84.26% <66.66%> (-0.28%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh, so before there was no comma between query=... and msg...? Good catch, good it's fixed.

@jawoznia
Copy link
Collaborator Author

jawoznia commented Nov 7, 2023

Uhh, so before there was no comma between query=... and msg...? Good catch, good it's fixed.

Unfortunately. I missed this check earlier.

@jawoznia jawoznia merged commit 05c0572 into main Nov 7, 2023
6 of 7 checks passed
@jawoznia jawoznia deleted the fix_custom branch November 7, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants