-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow specifying salt for contract address #259
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 86.52% 86.55% +0.02%
==========================================
Files 24 25 +1
Lines 1737 1740 +3
==========================================
+ Hits 1503 1506 +3
Misses 234 234 ☔ View full report in Codecov by Sentry. |
51c4e56
to
36d39b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature management has to improve
dd1c7c3
to
2986d45
Compare
2986d45
to
ff1d6ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly ok, but consider falling back to instantiate instead of hard error when using salt pre-1.2
No description provided.