Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Forward generics to custom_generic interface #265

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jawoznia
Copy link
Collaborator

part of #263

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ac645e) 87.25% compared to head (52eccee) 87.29%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/generics_forwarding     #265      +/-   ##
============================================================
+ Coverage                     87.25%   87.29%   +0.04%     
============================================================
  Files                            25       25              
  Lines                          1812     1811       -1     
============================================================
  Hits                           1581     1581              
+ Misses                          231      230       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but take a look at the comments before merging.

@jawoznia jawoznia force-pushed the custom_generic_interface branch 2 times, most recently from a6dd59d to 1e4c54a Compare November 27, 2023 11:19
Base automatically changed from generics_in_interface_implementation to feat/generics_forwarding November 30, 2023 14:27
@jawoznia jawoznia merged commit 66287d2 into feat/generics_forwarding Nov 30, 2023
7 checks passed
@jawoznia jawoznia deleted the custom_generic_interface branch November 30, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants