feat: Support duplicated exec generic params #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/generics_forwarding #273 +/- ##
=========================================================
Coverage 87.32% 87.32%
=========================================================
Files 25 25
Lines 1814 1814
=========================================================
Hits 1584 1584
Misses 230 230 ☔ View full report in Codecov by Sentry. |
jawoznia
force-pushed
the
duplicated_execs
branch
from
66cb692
to
c76dae9
Compare
hashedone
approved these changes
Dec 18, 2023
sylvia-derive/src/message.rs
Outdated
| @@ -830,6 +830,13 @@ impl<'a> MsgVariant<'a> { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: This could be made msg_type agnostic and stores map of msg_ty/variants. | |||
There was a problem hiding this comment.
Nope. Remove it from here, and create an issue about that. Noone ever tracked TODOs in code comments.
jawoznia
force-pushed
the
duplicated_execs
branch
from
c76dae9
to
3899ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #263