Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert breaking changes #416

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

jawoznia
Copy link
Collaborator

Revert breaking parts of
Refs:

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 26.19048% with 31 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (7fde418) to head (0da90d9).
Report is 5 commits behind head on main.

Files Patch % Lines
sylvia-derive/src/interface/communication/api.rs 45.00% 11 Missing ⚠️
sylvia/tests/interface_impl.rs 0.00% 11 Missing ⚠️
sylvia-derive/src/parser/entry_point.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   70.88%   70.12%   -0.77%     
==========================================
  Files          53       53              
  Lines        3050     3076      +26     
==========================================
- Hits         2162     2157       -5     
- Misses        888      919      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the jawoznia/revert_breaking_changes branch from 8bdc8b5 to def41c8 Compare August 21, 2024 14:22
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix changelog please, then we release that

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit 09414a0 into main Aug 22, 2024
7 of 9 checks passed
@jawoznia jawoznia deleted the jawoznia/revert_breaking_changes branch August 22, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants