Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make serde dep user side obsolete #422

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jawoznia
Copy link
Collaborator

Removed serde and cw_multi_test dependency from examples.
Fixed features in examples as some already non existent features were used in cfg checks. Also mt feature now enables sylvia/mt instead of cw_multi_test.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.08%. Comparing base (e8ede74) to head (9fdf78a).
Report is 1 commits behind head on main.

Files Patch % Lines
...a-derive/src/contract/communication/wrapper_msg.rs 0.00% 5 Missing ⚠️
...ia-derive/src/contract/communication/struct_msg.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   70.12%   70.08%   -0.05%     
==========================================
  Files          53       53              
  Lines        3080     3085       +5     
==========================================
+ Hits         2160     2162       +2     
- Misses        920      923       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Two comments to fix and we're good to go

Base automatically changed from jawoznia/feat/make_user_cw_schema_dep_obsolete to main August 27, 2024 08:05
@jawoznia jawoznia force-pushed the jawoznia/feat/make_user_serde_dep_obsolete branch from 7f7db18 to 9fdf78a Compare August 27, 2024 08:07
@jawoznia jawoznia merged commit e288914 into main Aug 27, 2024
7 of 9 checks passed
@jawoznia jawoznia deleted the jawoznia/feat/make_user_serde_dep_obsolete branch August 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants