Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate unique reply_ids (#427) #435

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Sep 2, 2024

No description provided.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.15%. Comparing base (778c5f0) to head (64daae9).
Report is 2 commits behind head on feat/replies.

Files with missing lines Patch % Lines
...ia-derive/src/contract/communication/struct_msg.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feat/replies     #435      +/-   ##
================================================
+ Coverage         69.88%   70.15%   +0.26%     
================================================
  Files                54       55       +1     
  Lines              3125     3156      +31     
================================================
+ Hits               2184     2214      +30     
- Misses              941      942       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the jawoznia/feat/generate_reply_id branch from 3efe3b5 to e02bf89 Compare September 3, 2024 07:27
@jawoznia jawoznia changed the title feat: Generate unique reply_ids feat: Generate unique reply_ids (#427) Sep 3, 2024
@jawoznia jawoznia linked an issue Sep 3, 2024 that may be closed by this pull request
@jawoznia jawoznia force-pushed the jawoznia/feat/generate_reply_id branch from e02bf89 to 3105f0e Compare September 4, 2024 10:45
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

sylvia-derive/src/types/msg_variant.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the jawoznia/chore/msg_attr_refactor branch from 76ceb1f to 15164b7 Compare September 17, 2024 12:19
Base automatically changed from jawoznia/chore/msg_attr_refactor to feat/replies September 17, 2024 12:37
@jawoznia jawoznia force-pushed the jawoznia/feat/generate_reply_id branch from c63c382 to 64daae9 Compare September 17, 2024 12:38
@jawoznia jawoznia merged commit f08901a into feat/replies Sep 17, 2024
9 checks passed
@jawoznia jawoznia deleted the jawoznia/feat/generate_reply_id branch September 17, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate ReplyIds
2 participants