[Do-not-merge] Upgrade to Cosmos-SDK v0.50. #1448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1059
to
+1066
| for _, m := range app.ModuleManager.Modules { | ||
| if moduleWithName, ok := m.(module.HasName); ok { | ||
| moduleName := moduleWithName.Name() | ||
| if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
| modules[moduleName] = appModule | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+1089
to
+1091
| for _, key := range app.keys { | ||
| keys = append(keys, key) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
sontrinh16
reviewed
Jun 22, 2023
(cherry picked from commit b29ba8b)
|
@alpe might be able to make a pr to fix now. |
use a more stable ibc-go
|
This branch is still very early integration only. I am going to rebase this on main later this week and open |
* use a more stable ibc-go * fix some small errors in accordance with what's working in ibc-go and wasmd * temporarily disable rosetta * add a few error checks and update some deprecated tendermint calls * error checks in export.go
|
@alpe sounds good to me. FYI:
should fix the Dockerfile's build |
|
Closing this in favour of #1528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WIP - early version
See #1438
Failing tests are deactivated. Go mod is setup my local workspace.
I am waiting for a soution in ibc-go that fixes the:
failed consensus state verification for client (07-tendermint-0): chained membership proof failed to verify membership of value:See upgrade doc in the SDK
I have started with just the go.mod dependencies and some related changes to imports.
This blocked now on the ibc-go release that includes the
capabilitymodule and fixed imports for sdk v0.50.This is also blocked on on some modules in the SDK that are not released. See
go.modreplacement statements for detailsSome notes on the work
New modules
Moved to
cosmossdk.iopathOthers
"github.com/cosmos/cosmos-sdk/snapshots -> "cosmossdk.io/store/snapshots
"github.com/cosmos/cosmos-sdk/client/grpc/tmservice -> "github.com/cosmos/cosmos-sdk/client/grpc/cmtservice
"github.com/cosmos/cosmos-sdk/x/capability -> "github.com/cosmos/ibc-go/v7/modules/capability
Removed: legacy proposals for x/upgrade
[(cosmos_proto.scalar) = "cosmos.AddressString"]for addresses in protocosmos.msg.v1.serviceproto annotation