Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to wasmvm 1.3.0-rc.0 (backport #1486) #1510

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 17, 2023

Resolves #1499
Part of #1492

Based on automatic backport of pull request #1486 done by Mergify.
Cherry-pick of 1a5a2d9 has failed: ...

Alex: I have fixed the merge conflicts manually

* Upgrade to wasmvm 1.3.0-rc.0

* Fix comments

(cherry picked from commit 1a5a2d9)

# Conflicts:
#	README.md
#	go.sum
#	x/wasm/client/cli/gov_tx.go
#	x/wasm/keeper/genesis_test.go
#	x/wasm/keeper/snapshotter_integration_test.go
@mergify mergify bot requested a review from alpe as a code owner July 17, 2023 12:44
@mergify mergify bot added the conflicts label Jul 17, 2023
@alpe alpe removed the conflicts label Jul 17, 2023
@alpe alpe requested review from pinosu and removed request for alpe July 17, 2023 13:28
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1510 (5c86330) into releases/v0.3x (e01f241) will decrease coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           releases/v0.3x    #1510      +/-   ##
==================================================
- Coverage           57.71%   57.68%   -0.04%     
==================================================
  Files                  57       57              
  Lines                7530     7534       +4     
==================================================
  Hits                 4346     4346              
- Misses               2877     2879       +2     
- Partials              307      309       +2     
Impacted Files Coverage Δ
x/wasm/types/proposal.go 53.07% <ø> (ø)
x/wasm/types/wasmer_engine.go 0.00% <ø> (ø)
x/wasm/client/cli/gov_tx.go 12.24% <33.33%> (-0.05%) ⬇️
x/wasm/types/test_fixtures.go 81.02% <50.00%> (-1.18%) ⬇️
x/wasm/keeper/keeper.go 87.57% <100.00%> (+0.31%) ⬆️
x/wasm/keeper/snapshotter.go 64.70% <100.00%> (ø)

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@pinosu pinosu merged commit c2a8e51 into releases/v0.3x Jul 18, 2023
7 of 8 checks passed
@mergify mergify bot deleted the mergify/bp/releases/v0.3x/pr-1486 branch July 18, 2023 13:28
This was referenced Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants