Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC Callbacks #1817

Merged
merged 20 commits into from
Jul 4, 2024
Merged

IBC Callbacks #1817

merged 20 commits into from
Jul 4, 2024

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Feb 29, 2024 •
edited
Loading

No description provided.

@chipshort chipshort force-pushed the ibc-callbacks branch 3 times, most recently from bd3eab3 to 692b398 Compare March 6, 2024 09:37
Base automatically changed from update-to-wasmvm-2.0 to main March 6, 2024 11:40
webmaster128
webmaster128 reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

tests/e2e/ibc_callbacks_test.go Outdated Show resolved Hide resolved
app/app.go Show resolved Hide resolved
srdtrk
srdtrk reviewed Apr 30, 2024
View reviewed changes
Copy link

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this amazing work.

go.mod Show resolved Hide resolved
x/wasm/ibc.go Show resolved Hide resolved
x/wasm/ibc.go Show resolved Hide resolved
x/wasm/ibc.go Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Show resolved Hide resolved
tests/e2e/ibc_callbacks_test.go Show resolved Hide resolved
@chipshort chipshort mentioned this pull request May 21, 2024
Merged
@webmaster128 webmaster128 added this to the 0.52 milestone Jun 27, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.49533% with 84 lines in your changes missing coverage. Please review.

Project coverage is 54.44%. Comparing base (5ae2f4a) to head (4a51e5b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
- Coverage   54.87%   54.44%   -0.44%     
==========================================
  Files          65       65              
  Lines        9775     9867      +92     
==========================================
+ Hits         5364     5372       +8     
- Misses       3866     3950      +84     
  Partials      545      545
Files Coverage Δ
app/app.go 85.95% <100.00%> (+0.17%) ⬆️
x/wasm/types/wasmer_engine.go 0.00% <ø> (ø)
x/wasm/keeper/relay.go 62.32% <0.00%> (-18.93%) ⬇️
x/wasm/ibc.go 54.31% <16.66%> (-14.76%) ⬇️

@chipshort chipshort marked this pull request as ready for review July 2, 2024 12:28
@chipshort chipshort mentioned this pull request Jul 3, 2024
Closed
6 tasks
webmaster128
webmaster128 reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great as far as I can tell

x/wasm/ibc.go Outdated Show resolved Hide resolved
x/wasm/ibc.go Outdated Show resolved Hide resolved
x/wasm/ibc.go Outdated Show resolved Hide resolved
webmaster128
webmaster128 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@chipshort
Copy link
Collaborator Author

I rebased on main. Can be merged if CI is happy

@chipshort chipshort merged commit 5657a01 into main Jul 4, 2024
1 of 3 checks passed
@chipshort chipshort deleted the ibc-callbacks branch July 4, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srdtrk srdtrk srdtrk left review comments

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.52
Development

Successfully merging this pull request may close these issues.
3 participants
@chipshort @webmaster128 @srdtrk