Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve async ack coverage #1919

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Improve async ack coverage #1919

merged 3 commits into from
Jul 3, 2024

Conversation

chipshort
Copy link
Collaborator

followup of #1876

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.79%. Comparing base (2e465b0) to head (6d42c0e).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
+ Coverage   54.68%   54.79%   +0.11%     
==========================================
  Files          65       65              
  Lines        9857     9857              
==========================================
+ Hits         5390     5401      +11     
+ Misses       3919     3901      -18     
- Partials      548      555       +7     

see 1 file with indirect coverage changes

x/wasm/keeper/handler_plugin_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/handler_plugin_test.go Outdated Show resolved Hide resolved
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@chipshort chipshort merged commit a7f708c into main Jul 3, 2024
16 checks passed
@chipshort chipshort deleted the co/async-ack-test branch July 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants