Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cosmos-sdk to v0.52 #2005

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ibc dependency
pinosu committed Nov 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 64da41a3e2ea5c530980baf65eb5ca96a8d00b21
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
@@ -298,8 +298,8 @@ replace (
// pseudo version lower than the latest tag
github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.0.0-20241108061010-a0458127fccf

github.com/cosmos/ibc-go/modules/apps/callbacks => github.com/alpe/ibc-go/modules/apps/callbacks v0.0.0-20241109123747-a8b8a35b6521
github.com/cosmos/ibc-go/v9 => github.com/alpe/ibc-go/v9 v9.0.0-20241109123747-a8b8a35b6521
github.com/cosmos/ibc-go/modules/apps/callbacks => github.com/pinosu/ibc-go/modules/apps/callbacks v0.0.0-20241113155047-e87c7ed6c158
github.com/cosmos/ibc-go/v9 => github.com/pinosu/ibc-go/v9 v9.0.0-20241113155047-e87c7ed6c158
)

retract (
8 changes: 4 additions & 4 deletions go.sum
Original file line number Diff line number Diff line change
@@ -289,10 +289,6 @@ github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuy
github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
github.com/alpe/ibc-go/modules/apps/callbacks v0.0.0-20241109123747-a8b8a35b6521 h1:SZzgA0iGLDaJ8N1Pz7JZ/ACeHArQx7O8g2nnWhwnfHw=
github.com/alpe/ibc-go/modules/apps/callbacks v0.0.0-20241109123747-a8b8a35b6521/go.mod h1:tTsl/fN8zPRB1GP5mz+q7F0Q/LLxbI4OzGHqbNi8XnE=
github.com/alpe/ibc-go/v9 v9.0.0-20241109123747-a8b8a35b6521 h1:mknQbT/K4owGTsPaZ2pOGXVMwV4TM/N0pYMZWriJerw=
github.com/alpe/ibc-go/v9 v9.0.0-20241109123747-a8b8a35b6521/go.mod h1:GIH95bzq6vZvL30UVivLfd1P4c71v92OB1a7JmutHxw=
github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
github.com/aws/aws-sdk-go v1.44.122/go.mod h1:y4AeaBuwd2Lk+GepC1E9v0qOiTws0MIWAX4oIKwKHZo=
github.com/aws/aws-sdk-go v1.54.6 h1:HEYUib3yTt8E6vxjMWM3yAq5b+qjj/6aKA62mkgux9g=
@@ -785,6 +781,10 @@ github.com/petermattis/goid v0.0.0-20240813172612-4fcff4a6cae7 h1:Dx7Ovyv/SFnMFw
github.com/petermattis/goid v0.0.0-20240813172612-4fcff4a6cae7/go.mod h1:pxMtw7cyUw6B2bRH0ZBANSPg+AoSud1I1iyJHI69jH4=
github.com/pingcap/errors v0.11.4 h1:lFuQV/oaUMGcD2tqt+01ROSmJs75VG1ToEOkZIZ4nE4=
github.com/pingcap/errors v0.11.4/go.mod h1:Oi8TUi2kEtXXLMJk9l1cGmz20kV3TaQ0usTwv5KuLY8=
github.com/pinosu/ibc-go/modules/apps/callbacks v0.0.0-20241113155047-e87c7ed6c158 h1:CHov+zlr04c5SwswizsRai1iyNjD/gv09l5PxkTNK+U=
github.com/pinosu/ibc-go/modules/apps/callbacks v0.0.0-20241113155047-e87c7ed6c158/go.mod h1:wXMCjeAOG4Q8XeKLSlWf21UJYgSIW5qRiQ0K3/rwMaU=
github.com/pinosu/ibc-go/v9 v9.0.0-20241113155047-e87c7ed6c158 h1:1x4MyE2ZvPESDPofta7jq7HPPYuI+1AZ5JgU8AMBam4=
github.com/pinosu/ibc-go/v9 v9.0.0-20241113155047-e87c7ed6c158/go.mod h1:guBTopaAvk9ph4Zzc2gbGW37Hj0jZu8Ra0lR9c5RXcQ=
github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=

Unchanged files with check annotations Beta

}
app.AccountsKeeper = accountsKeeper
app.AuthKeeper = authkeeper.NewAccountKeeper(runtime.NewEnvironment(runtime.NewKVStoreService(keys[authtypes.StoreKey]), logger.With(log.ModuleKey, "x/auth")), appCodec, authtypes.ProtoBaseAccount, accountsKeeper, maccPerms, signingCtx.AddressCodec(), sdk.Bech32MainPrefix, govModuleAddr)

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning

Directly using the bech32 constants instead of the configuration values
blockedAddrs, err := BlockedAddresses(signingCtx.AddressCodec())
if err != nil {
app.ConsensusParamsKeeper,
govModuleAddr,
signingCtx.ValidatorAddressCodec(),
authcodec.NewBech32Codec(sdk.Bech32PrefixConsAddr),

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning

Directly using the bech32 constants instead of the configuration values
cometService,
)
var icaControllerStack porttypes.IBCModule
// integration point for custom authentication modules
// see https://medium.com/the-interchain-foundation/ibc-go-v6-changes-to-interchain-accounts-and-how-it-impacts-your-chain-806c185300d7
icaControllerStack = icacontroller.NewIBCMiddleware(app.ICAControllerKeeper)

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of icaControllerStack is never used.
// app.ICAAuthModule = icaControllerStack.(ibcmock.IBCModule)
icaControllerStack = icacontroller.NewIBCMiddleware(app.ICAControllerKeeper)
icaControllerStack = ibccallbacks.NewIBCMiddleware(icaControllerStack, app.IBCFeeKeeper, wasmStackIBCHandler, wasm.DefaultMaxIBCCallbackGas)
var bankGenState banktypes.GenesisState
clientCtx.Codec.MustUnmarshalJSON(appGenState[banktypes.ModuleName], &bankGenState)
bankGenState.Balances, err = banktypes.SanitizeGenesisBalances(genBalances, clientCtx.AddressCodec)

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning test

This definition of err is never used.
for _, bal := range bankGenState.Balances {
bankGenState.Supply = bankGenState.Supply.Add(bal.Coins...)
}
consensusParamsKeeper,
govModuleAddr,
appCodec.InterfaceRegistry().SigningContext().ValidatorAddressCodec(),
authcodec.NewBech32Codec(sdk.Bech32PrefixConsAddr),

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning test

Directly using the bech32 constants instead of the configuration values
cometService,
)
stakingtypes.DefaultParams()