Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed multiple issues related to values with decimal points #7

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Fixed multiple issues related to values with decimal points #7

wants to merge 14 commits into from

Conversation

manish-in-java
Copy link

I had run into and fixed the following problems with the plugin:

  1. Precision specified when initialising the plugin was not being used for typed values. For example, I could type 999.9999 with precision of 2;
  2. Minimum value specified when initialising the plugin was not being used for typed values. For example, I could type 100 with a minimum value of 1000;
  3. Maximum value specified when initialising the plugin was not being used for typed values. For example, I could type 100 with a maximum value of 99;
  4. I could type a value with a decimal point even after initialising the plugin with int type;
  5. Float values lost decimal point when using the up and down buttons. For example, if I initialised a control with the value 100.00, with a precision of 2, the value would become 99 on using the down button and 101 on using the up down, although the expected values would be 99.00 and 101.00 respectively.

Please review and merge if appropriate.

manish-in-java and others added 14 commits June 21, 2013 12:44
@manish-in-java
Update jquery.stepper.js
e80784d 
Fixed the following issues:

1. User can type a decimal point when using type = "int";
2. User can type a value less than the minimum limit set for the control;
3. User can type a value with more number of digits after the decimal point than configured.
@manish-in-java
Update jquery.stepper.min.js
63175fd
@manish-in-java
Update jquery.stepper.css
2450198
@manish-in-java
Update jquery.stepper.min.css
ada4462
Fixed problems related to the use of backspace and delete keys with t…
b91ce1d 
…he plugin.
Updates to code to make the plugin work on IE9+.
ef0d8dc
@manish-in-java
Upgraded plugin so that it does not change values for input controls …
d8857d1 
…that are currently disabled.
@manish-in-java
Added a horizontal layout where the increment and decrement buttons a…
4585019 
…ppear in a horizontal line along with the text box.

Replaced pixel based measurements in the CSS file with em to allow elements to automatically scale with changes in font size.
@manish-in-java
Moved variable declaration to correct location so that it is availabl…
90284f9 
…e for reference later.
@manish-in-java
Reduced font size for the buttons for better look-and-feel.
a21040d
@manish-in-java
Fixed CSS for horizontal layout so that the control does not break wh…
68290f1 
…en placed next to a block element.
@manish-in-java
Replaced the use of the keydown event with keypress event as the key …
c71e13a 
…codes passed to the later are rationalized such that codes for numbers pressed on the regular number bar and those on numeric keypads are the same, whereas they are not the same for the former.
@manish-in-java
Corrected handling of arrow keys.
746f035
@manish-in-java
Added colour options for stepper control.
3415f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manish-in-java