Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribers data added to databse #1296

Closed
wants to merge 3 commits into from

Conversation

dhruv8433
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

@thestarsahil

[Feat] : Store Subsciber data in database #1278

Fixes #1278(issue_no)

Replace issue_no with the issue number which is fixed in this PR

Screenshots

image

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

Copy link

netlify bot commented Jul 29, 2024

👷 Deploy request for counsellor-startup pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3c82566

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Contributor

deepsource-io bot commented Jul 29, 2024

Here's the code health analysis summary for commits 88430b7..3c82566. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 2 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@thestarsahil
Copy link
Collaborator

Its showing on console log , not on firebase database

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jul 29, 2024

@thestarsahil

now check that
i am tested that by logging all emails in console and i got all subscribers data
currently in code i removed console of all users

image

check this image i got all subscribers

check this video

Counsellor.Portal.Mozilla.Firefox.2024-07-29.13-03-43.online-video-cutter.com.mp4

@dhruv8433
Copy link
Contributor Author

@thestarsahil

please check this and merge it

@thestarsahil
Copy link
Collaborator

That's how data not stored in database @dhruv8433
Attacker can easily read the code you written and showing all mail in console log

@dhruv8433
Copy link
Contributor Author

@thestarsahil

I removed that part of code
I just conform that data is stored or not in database

You can check live preview the console not displayed

@dhruv8433
Copy link
Contributor Author

@thestarsahil

please check this
i fetched upstream and remove unnecessary console

it will store subscibers data in newsletter/emails table

@thestarsahil
Copy link
Collaborator

thestarsahil commented Jul 30, 2024

@nishant0708 Can you help him to get fetch data into database

@nishant0708
Copy link
Contributor

hey @dhruv8433 @thestarsahil i think its already working
image
see

@nishant0708
Copy link
Contributor

hey @dhruv8433 if task was different so please connect me on discord i will help you with this Vc

Copy link

This PR has been automatically closed due to inactivity from the owner for 15 days.

@github-actions github-actions bot added the Stale label Aug 15, 2024
@github-actions github-actions bot closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] : Store Subsciber data in database
3 participants