[v10.4.3] New Transaction Composer #2272
Conversation
ouziel-slama
commented
Sep 27, 2024
ouziel-slama
commented
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
adamkrellenstein
changed the title
| raise exceptions.TransactionError(f"Not supported encoding: {encoding}") | ||
|
|
||
|
|
||
| def prepare_outputs(source, destinations, data, pubkeys, encoding, arc4_key=None): |
Check warning
Code scanning / pylint
Too many positional arguments (6/5). Warning
| return get_needed_fee(tx, satoshis_per_vbyte) | ||
|
|
||
|
|
||
| def compose_transaction( |
Check warning
Code scanning / pylint
Too many positional arguments (8/5). Warning
| source, destinations, data, pubkeys, encoding, arc4_key=inputs[0]["txid"] | ||
| ) | ||
| tx = CTransaction(inputs, outputs + change_outputs) | ||
| btc_out = sum(output.nValue for output in outputs) |
Check warning
Code scanning / pylint
Instance of 'TxOutput' has no 'nValue' member. Warning
|
|
||
| def get_minimum_change(source): | ||
| if script.is_multisig(source): | ||
| return config.MULTISIG_DUST_SIZE |
Check warning
Code scanning / pylint
Module 'counterpartycore.lib.config' has no 'MULTISIG_DUST_SIZE' member. Warning
| def get_minimum_change(source): | ||
| if script.is_multisig(source): | ||
| return config.MULTISIG_DUST_SIZE | ||
| return config.REGULAR_DUST_SIZE |
Check warning
Code scanning / pylint
Module 'counterpartycore.lib.config' has no 'REGULAR_DUST_SIZE' member. Warning
