Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.4.3] Fixes #2292

Merged
merged 8 commits into from
Oct 3, 2024
Merged

[v10.4.3] Fixes #2292

merged 8 commits into from
Oct 3, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Oct 2, 2024

  • fix NULL asset_events
  • Add test for DISPENSE in mempool
  • In the result of /v2:
    - use the github repo for the blueprint url
    - add the route routes: /v2/routes
  • Add addresses argument for /v2/mempool/events route
  • Add routes to get assets by issuer or owner
  • Add prefixed data support to api.compose.unpack() function

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@@ -1963,6 +1980,64 @@
)


def get_valid_assets_by_owner(

Check warning

Code scanning / pylint

Too many positional arguments (6/5). Warning

Too many positional arguments (6/5).
)


def get_valid_assets_by_issuer_or_owner(

Check warning

Code scanning / pylint

Too many positional arguments (6/5). Warning

Too many positional arguments (6/5).
@ouziel-slama ouziel-slama marked this pull request as ready for review October 3, 2024 13:12
@ouziel-slama ouziel-slama merged commit 519a306 into develop Oct 3, 2024
17 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch October 3, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants