Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile Rework #423

Open
wants to merge 13 commits into
base: staging
Choose a base branch
from
Open

User Profile Rework #423

wants to merge 13 commits into from

Conversation

AliRKat
Copy link
Contributor

@AliRKat AliRKat commented Nov 5, 2024

Reasons of in this rework:

  • Some of the methods were not following the naming conventions we follow in all SDKs (pushValue, pullValue etc.)
  • Support for all primitive types and array types in custom user details
  • Directly added UserProfile.js because having everything inside Countly.js is not a good idea IMO.
  • Old methods were returning messages, which is something we want to move away from, new calls are void

Note: There's also userDataBulk in Countly.js, haven't done anything about that one yet but we can also deprecate that one and apply the same structure to it, wanted to ask about that one first

@AliRKat AliRKat added the draft label Nov 5, 2024
@AliRKat
Copy link
Contributor Author

AliRKat commented Nov 6, 2024

[RN] User Profile Rework

Copy link
Member

@arifBurakDemiray arifBurakDemiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Ali-dono 🙇
There are just some cuple de issues.

UserProfile.js Outdated Show resolved Hide resolved
UserProfile.js Show resolved Hide resolved
UserProfile.js Outdated Show resolved Hide resolved
UserProfile.js Show resolved Hide resolved
Validators.js Outdated Show resolved Hide resolved
@AliRKat AliRKat requested a review from turtledreams November 12, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants