Reduce github api calls in hashtable syncing from 2 to 1 #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Octokit only gets 60 api calls per hour, which is pretty low, especially considering Obsidian can do up to 3 api calls on startup (2 for hashtable syncing, 1 for self update check). I have hit this myself when doing testing and could imagine other people hitting it, so here's a free optimization that merges both hashtable api calls into one.
Not entirely happy with this being a class field but this is all only called once anyway, so I don't think doing anything advanced is necessary here.