Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTL-2458 #417

Merged
merged 2 commits into from
Sep 3, 2024
Merged

MTL-2458 #417

merged 2 commits into from
Sep 3, 2024

Conversation

jpdavis-prof
Copy link
Contributor

@jpdavis-prof jpdavis-prof commented Aug 30, 2024 •
edited
Loading

Summary and Scope

https://jira-pro.it.hpe.com:8443/browse/MTL-2458

Issue Type

  • RFE Pull Request

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (if yes, please include results or a description of the test)

@jpdavis-prof jpdavis-prof requested a review from a team as a code owner August 30, 2024 22:33
rustydb
rustydb requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@rustydb rustydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to maintain backwards compatibility with CSM 1.4 and 1.5.

pkg/kubernetes/utils.go Show resolved Hide resolved
@jpdavis-prof
MTL-2458
fbbc7fb 
allow for node-role.kubernetes.io/master and node-role.kubernetes.io/control-plane
@jpdavis-prof jpdavis-prof merged commit 2452e08 into main Sep 3, 2024
8 checks passed
@jpdavis-prof jpdavis-prof deleted the MTL-2458 branch September 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leliasen-hpe leliasen-hpe leliasen-hpe approved these changes

@rustydb rustydb rustydb approved these changes

@spillerc-hpe spillerc-hpe Awaiting requested review from spillerc-hpe spillerc-hpe is a code owner automatically assigned from Cray-HPE/metal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpdavis-prof @rustydb @leliasen-hpe