Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required tenant prompt when initializing (CASMPET-6649) #121

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

bklei
Copy link

@bklei bklei commented Jun 29, 2023

Summary and Scope

Change --tenant argument to be optional to prevent BW incompatible change for non-interactive use cases.

Issues and Related PRs

Testing

Tested on ashton:

ncn-m003:~/.config/cray/configurations # cray init --hostname https://api-gw-service-nmn.local
Overwrite configuration file at: /root/.config/cray/configurations/default ? [y/N]: y
Username: vshasta
Password:
Success!

Initialization complete.
ncn-m003:~/.config/cray/configurations # cat default
[core]
hostname = "https://api-gw-service-nmn.local"
tenant = ""

[auth.login]
username = "vshasta"
ncn-m003:~/.config/cray/configurations # cray init --hostname https://api-gw-service-nmn.local --tenant vcluster-blue
Overwrite configuration file at: /root/.config/cray/configurations/default ? [y/N]: y
Username: vshasta
Password:
Success!

Initialization complete.

ncn-m003:~/.config/cray/configurations # cat default
[core]
hostname = "https://api-gw-service-nmn.local"
tenant = "vcluster-blue"

[auth.login]
username = "vshasta"

Was a fresh Install tested? N
Was an Upgrade tested? N - N/A
Was a Downgrade tested? N - N/A
If schema changes were part of this change, how were those handled in your upgrade/downgrade testing? N/A

Risks and Mitigations

Low

Requires:

  • Nothing

@bklei bklei marked this pull request as ready for review June 29, 2023 16:07
@heemstra heemstra merged commit 2a9c6a8 into master Jun 29, 2023
@heemstra heemstra deleted the CASMPET-6649-1.5 branch June 29, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants