Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASM-4467 stable 1.5 #2580

Merged
merged 1 commit into from
Jul 20, 2023
Merged

CASM-4467 stable 1.5 #2580

merged 1 commit into from
Jul 20, 2023

Conversation

atifsyedali
Copy link
Contributor

Summary and Scope

Cray-cli recently introduced a -tenant option as part of cray init command. When it was introduced, this tenant flag was required. However, this caused issues with existing scripts as none of them supplied the -tenant flag.

The -tenant flag was then made optional. However, the iuf-container image still used the version of cray-cli where the -tenant flag was required. This is causing issues in deliver-product and deploy-product stages.

Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?

Yes

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Testing

Tested on:

  • Wasp
  • Surtur

Test description:

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

Ran IUF

Risks and Mitigations

Are there known issues with these changes? Any other special considerations?

No

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@atifsyedali atifsyedali requested a review from a team as a code owner July 19, 2023 17:15
@denniswalker denniswalker merged commit 17c7e24 into stable/1.5 Jul 20, 2023
@denniswalker denniswalker deleted the CASM-4467-stable-1.5 branch July 20, 2023 19:35
@denniswalker
Copy link
Contributor

/backport release/1.5

@github-actions
Copy link

Backporting into branch release/1.5 was successful. New PR: #2592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants