CRAYSAT-1750: Update PyYAML to 6.0.1 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PyYAML to 6.0.1 to fix a build error. This build error was due to an incompatible change introduced in Cython 3.0. The PyYAML package has worked around this in version 6.0.1 by restricting to Cython<3.0. Also update the pinned version of csm-api-client to 1.1.5, which relaxed the PyYAML constraint to allow versions greater than or equal to 6.0. Without this change, `pip` is unable to resolve sat's dependencies. Test Description: Ran the following `sat` commands to exercise relevant code: * `sat showrev --products` (config map access) * `sat bootprep run` (YAML loading, API access, config map access) * `sat status` (multiple API access)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Update PyYAML to 6.0.1 to fix a build error. This build error was due to an incompatible change introduced in Cython 3.0. The PyYAML package has worked around this in version 6.0.1 by restricting to Cython<3.0.
Also update the pinned version of csm-api-client to 1.1.5, which relaxed the PyYAML constraint to allow versions greater than or equal to 6.0. Without this change,
pipis unable to resolve sat's dependencies.Testing
Tested on:
Test description:
Ran the following
satcommands to exercise relevant code:sat showrev --products(config map access)sat bootprep run(YAML loading, API access, config map access)sat status(multiple API access)Risks and Mitigations
Low risk since we're just pulling in new PyYAML.
Pull Request Checklist