Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboards are incorrectly marked as NBT safe #6543

Open
rybot666 opened this issue May 30, 2024 · 0 comments · May be fixed by #6928
Open

Clipboards are incorrectly marked as NBT safe #6543

rybot666 opened this issue May 30, 2024 · 0 comments · May be fixed by #6928
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working

Comments

@rybot666
Copy link

rybot666 commented May 30, 2024

Describe the Bug

Clipboards are incorrectly marked as NBT-safe, despite copying an item stack blindly from their NBT data. This means that printing a malicious schematic containing a clipboard block can spawn any item once the clipboard is broken.

Reproduction Steps

  1. Take a schematic of a placed clipboard block
  2. Open it in an NBT editor
  3. Modify the Item tag of the clipboard block entity to contain whatever you want
  4. Print the schematic with a schematicannon
  5. Break the placed clipboard

Expected Result

The NBT should be verified to make sure the item is actually a clipboard.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Forge Version

36.2.0

Other Mods

No response

Additional Context

No response

@rybot666 rybot666 added the type: bug Issue where something isn't working label May 30, 2024
@IThundxr IThundxr added the status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix label Sep 4, 2024
MoePus added a commit to MoePus/Create that referenced this issue Sep 10, 2024
@MoePus MoePus linked a pull request Sep 10, 2024 that will close this issue
MoePus added a commit to MoePus/Create that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Issue's details are known, it is consistently reproducible, and it needs a fix type: bug Issue where something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants