Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement writeSafe for ClipboardBlockEntity #6928

Open
wants to merge 2 commits into
base: mc1.20.1/dev
Choose a base branch
from
Open

implement writeSafe for ClipboardBlockEntity #6928

wants to merge 2 commits into from

Conversation

MoePus
Copy link

@MoePus MoePus commented Sep 10, 2024

fix #6543

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Sep 10, 2024
VoidLeech
VoidLeech reviewed Sep 10, 2024
View reviewed changes
src/generated/resources/data/create/tags/blocks/safe_nbt.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be datagenned,

Create/src/main/java/com/simibubi/create/AllBlocks.java

Line 1959 in aa15182

.tag(AllBlockTags.SAFE_NBT.tag)
so it's not overwritten when additional datagen happens.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗，fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoidLeech VoidLeech VoidLeech left review comments

Assignees
No one assigned
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clipboards are incorrectly marked as NBT safe
3 participants
@MoePus @VoidLeech @IThundxr