Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IC2 compat recipes using the wrong items #6917

Closed

Conversation

IThundxr
Copy link
Collaborator

@IThundxr IThundxr commented Sep 7, 2024

Fixes #6916

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Sep 7, 2024
@PepperCode1
Copy link
Member

I don't agree with this implementation. I think it would be better to add a CompatMetal.getName(Mods) overload and have the metal itself provide the correct name for the passed mod. The existing overload should stay to provide the default name.

@IThundxr
Copy link
Collaborator Author

IThundxr commented Sep 7, 2024

I don't agree with this implementation. I think it would be better to add a CompatMetal.getName(Mods) overload and have the metal itself provide the correct name for the passed mod. The existing overload should stay to provide the default name.

Yeah that works aswell

@Foreverly-xmz
Copy link

hello, this might be very impolite to ask here and i apologize in advance. Ive checked the dev status for 1.21 and there has been any updates. I was wondering how close you guys are to releasing it? ive been wanting to play a create survival world but before i start in 1.20.1, i wanted to see if maybe i wouldnt have to wait long, and if i should wait for 1.21.

@zOnlyKroks
Copy link

hello, this might be very impolite to ask here and i apologize in advance. Ive checked the dev status for 1.21 and there has been any updates. I was wondering how close you guys are to releasing it? ive been wanting to play a create survival world but before i start in 1.20.1, i wanted to see if maybe i wouldnt have to wait long, and if i should wait for 1.21.

Completly and utterly unrelated to the merge request. Id suggest asking on the discord

@davv1
Copy link

davv1 commented Sep 18, 2024

Will this fix also be applied to 1.19.2 version? Same error happened for my group when we tried to start fresh server with IC2C.

Sorry if this is noob question, I'm asking because I see it mentions 1.20.1 branch 😊

@IThundxr IThundxr changed the base branch from mc1.20.1/dev to mc1.18/dev September 18, 2024 19:41
simibubi added a commit that referenced this pull request Oct 8, 2024
- Fixed incorrect IC2 compatibility recipes #6917 #6916
@simibubi
Copy link
Collaborator

simibubi commented Oct 8, 2024

Thanks, this has been implemented in 8f5c91c

@simibubi simibubi closed this Oct 8, 2024
@IThundxr IThundxr deleted the mc1.20.1/compat-fix branch October 8, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IC2 Compat Recipes crash the game
6 participants