Null-check multiblock controllers when disassembling #6943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases, a second contraption can pick up multiblocks too quickly and the "prevControllerInfo" ends up null, crashing the game/server. Fixes Creators-of-Create#6915 and Creators-of-Create#6925
IThundxr
added
pr type: fix
simibubi
added a commit
that referenced
this pull request
Oct 8, 2024
|
Thanks, has been merged as apart of 2828c88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We run a public Create server (running Minecraft
1.20.1) and it started crashing pretty regularly after updating to0.5.1h. Did some digging and found it's the same issue as #6915, albiet with gantries rather than pistons.My understanding is: in rare cases, a second contraption can pick up multi-blocks too quickly and the
prevControllerInfoends up null, crashing the game/server. I suspect there might be a "better" solution of kinda "doing it right" to prevent thenullfrom appearing in the first place, but my knowledge of the Create codebase is limited and this at least stops the server from crashing from this.Fixes #6915 and #6925