Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init profiles worker with member affiliations update #1962

Merged
merged 17 commits into from
Jan 8, 2024

Conversation

loicsaintroch
Copy link
Member

@loicsaintroch loicsaintroch commented Dec 13, 2023

Changes proposed ✍️

What

🤖[deprecated] Generated by Copilot at 80fba34

This pull request introduces a new profiles-worker service that uses Temporal workflows to update member affiliations in the database. It adds a new directory services/apps/profiles_worker that contains the service code, configuration, and types. It also adds a new Dockerfile, a Docker Compose configuration, and a shell script for building and running the service. It modifies the existing GitHub workflows and the memberRepository.ts file to use the profiles-worker service instead of the old logic. It updates the pnpm-lock.yaml file to reflect the new dependencies for the service.

🤖[deprecated] Generated by Copilot at 80fba34

We unleash the profiles-worker
To orchestrate the member fate
With Temporal and Docker
We deploy and update at a blazing rate

Why

How

🤖[deprecated] Generated by Copilot at 80fba34

  • Add a new profiles-worker service that handles the logic for updating member affiliations using Temporal workflows and activities (link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Replace the calls to MemberAffiliationRepository.update in the backend service with calls to options.temporal.workflow.start that start the memberUpdate workflow defined by the profiles-worker service (link, link, link)
  • Remove the unused import of MemberAffiliationRepository from the backend service and add the import of TemporalWorkflowId enum from the @crowd/types package (link, link, link)
  • Add a new input parameter deploy_profiles_worker to the GitHub workflows for deploying to the LF production, production, and staging environments that allows the user to choose whether to deploy the profiles-worker service or not (link, link)
  • Add new jobs build-and-push-profiles-worker and deploy-profiles-worker to the GitHub workflows for deploying to the LF production, production, and staging environments that build and push the Docker image for the profiles-worker service and deploy the service to the respective clusters using AWS EKS and Helm (link, link, link, link)
  • Add new GitHub workflows for deploying the profiles-worker service to the LF staging and staging environments that are triggered by push events to the lf-staging/**, lf-staging-**, staging/**, or staging-** branches that affect the profiles-worker service or its dependencies (link, link)
  • Update the version of the uuid package from 8.3.0 to 8.3.2 and remove the unused resolution for the [email protected] package in the pnpm-lock.yaml file (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanreyero joanreyero removed the request for review from themarolt December 17, 2023 23:36
@loicsaintroch loicsaintroch merged commit fc79c4b into main Jan 8, 2024
8 checks passed
@loicsaintroch loicsaintroch deleted the improvement/async-member-affiliations-update branch January 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant