Organization common view #2581
Organization common view #2581
Conversation
…ev into improvement/org-view
…ev into improvement/org-view
…ev into improvement/org-view
…ev into improvement/org-view
There was a problem hiding this comment.
Some other issues I found:
- Remove "Merge organization" button for Organization profile when it's across segments
organizationsToMergeendpoint is failing in profile, but I think it's because you are not passing any segments in. I think it should no longer be a problem, once the merge button is removed.- number of people in community snapshot, People tab and Activities tab are broken on Organization profile. Again, this is because no segment ids are being passed to the endpoints. Somehow, frontend will need to know to which projects this organization is associated to, and pass those segment ids in the profile request
- Another thing that is missing is the filter Nuno designed in the community snapshot (screenshot below). Again, you will need a list of associated projects in the profile to be able to render this
frontend/src/modules/organization/components/list/organization-common-list-table.vue
Show resolved
Hide resolved
frontend/src/modules/organization/pages/organization-common-page.vue
Outdated
Show resolved
Hide resolved
frontend/src/modules/organization/pages/organization-common-page.vue
Outdated
Show resolved
Hide resolved
…ev into improvement/org-view
…ev into improvement/org-view
There was a problem hiding this comment.
Hey filters are still not ok. In this specific page we only want to show a limited amount of filters, since we also don't show all columns.
Can you check the comment and designs?
Another thing I noticed is that it seems that activity count and activities tab in the organizations profile is not ok. Neither for organizations in a selected project group or for all project groups.
In community snapshot, activity count is always 0 and in Activities tab, spinner just keeps loading. Can you check it out?
| }, | ||
| { | ||
| headers: { | ||
| 'x-crowd-api-version': '1', | ||
| }, | ||
| }, | ||
| ); | ||
| console.log(response); |
| :search-config="organizationSearchFilter" | ||
| :saved-views-config="commonOrganizationSavedViews" | ||
| hash="organizations" | ||
| class="pb-1" | ||
| @fetch="fetch($event)" | ||
| /> |
There was a problem hiding this comment.
We shouldn't use all organization filters: :config="organizationFilters"
List of filters is in the designs -> https://www.figma.com/design/CqK8KzwZFdPk7u3aypgT5a/2.-LFX-CM-%7C-Product---Admin?node-id=206-12020&t=qGHovB2TheRKggp4-4
There was a problem hiding this comment.
Hey I'm still seeing some issues, listing them below. Design link: https://www.figma.com/design/CqK8KzwZFdPk7u3aypgT5a/2.-LFX-CM-%7C-Product---Admin?node-id=14-2
Issue 1: For organizations profile with selected project group, activity count is showing 0 but as you can see in the screenshot there are activities. Also there are activities in the activities tab.
Issue 2: For organizations profile across all segments (no selected project group), you are no longer showing the "All associated project groups" filter in the Community snapshot
Now:
Issue 3: Table doesn't have pagination. There are over 300 results in the list, and I'm only able to see 20
Now:
How it should be:
Issue 4: Filters names are not matching the designs... Please check the design
Now:
What it should be:
Changes proposed ✍️
What
copilot:summary
copilot:poem
Why
How
copilot:walkthrough
Checklist ✅
Feature,Improvement, orBug.