Align main menu for lf design #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanagmaia
reviewed
Sep 18, 2024
There was a problem hiding this comment.
If you notive on the top right of the menu, we have a border radius on the main container of the page. Now that we have this new menu I believe this should no longer exist. I believe these are the classes where it is being applied el-container bg-white rounded-tl-2xl
Comment on lines
148
to
151
| <style lang="scss"> | ||
|
|
||
| .app-menu { | ||
| --el-menu-base-level-padding: 24px; |
There was a problem hiding this comment.
Do we still need this scss at all?
| @apply border-r border-gray-200 bg-white py-4 flex flex-col transition-all; | ||
|
|
||
| &__link{ | ||
| @apply w-full flex flex-nowrap items-center border-l-3 h-9 px-5 text-gray-900 text-medium; |
There was a problem hiding this comment.
All menu items have a left gray border when they are not selected. I believe this shouldn't exist
joanagmaia
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
copilot:summary
copilot:poem
Why
How
copilot:walkthrough
Checklist ✅
Feature,Improvement, orBug.