Skip to content

Commit

Permalink
CI improvements, including new checks/tests under PHP 8.3
Browse files Browse the repository at this point in the history
  • Loading branch information
deminy committed Dec 1, 2023
1 parent 8c2a7e9 commit eaf598d
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 8 deletions.
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

# Ignore test output
/.phplint-cache
/.phplint.cache

# Ignore Docker files
/Dockerfile
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coding_style_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Run Coding Style Checks
run: docker run --rm -v "$(pwd):/project" -w /project -i jakzal/phpqa:php8.2 phpcs -v --standard=PSR2 src tests/unit
2 changes: 1 addition & 1 deletion .github/workflows/syntax_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Run Syntax Checks
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ jobs:
strategy:
fail-fast: false
matrix:
php: ["7.3", "7.4", "8.0", "8.1", "8.2"]
php: ["7.3", "7.4", "8.0", "8.1", "8.2", "8.3"]

name: Tests Under PHP ${{ matrix.php }}

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Services
run: |
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

# Ignore test output
/.phplint-cache
/.phplint.cache

# Ignore Composer files
/composer.lock
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"require-dev": {
"guzzlehttp/guzzle": "~7.0",
"phpunit/phpunit": "~9.0",
"psr/simple-cache": "~1.0",
"symfony/cache": "~5.0"
"psr/simple-cache": ">=1.0",
"symfony/cache": ">=5.0"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/BasicTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function setUp(): void
BackgroundProcessing::reset();
}

public function dataRun(): array
public static function dataRun(): array
{
$closure = function (int ...$params) {
self::$counter += array_sum($params);
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/DockerizedTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*/
class DockerizedTest extends TestCase
{
public function dataRun(): array
public static function dataRun(): array
{
return [
[
Expand Down

0 comments on commit eaf598d

Please sign in to comment.