Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a function to enable custom logging #622

Merged
merged 1 commit into from
Apr 11, 2024
Merged

add a function to enable custom logging #622

merged 1 commit into from
Apr 11, 2024

Conversation

frett
Copy link
Contributor

@frett frett commented Apr 11, 2024

No description provided.

@frett
Copy link
Contributor Author

frett commented Apr 11, 2024

@levieggertcru this replicates the custom logging capability we setup for Napier, and moves it into the common module for now so that it doesn't need any special logic to be included in your SPM work.

Long term this may be moved to a different location that makes more sense for platform glue logic, I'm just not sure right now

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 85.47%. Comparing base (72035ec) to head (86bd478).

Files Patch % Lines
.../org/cru/godtools/shared/common/logging/Logging.kt 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   86.31%   85.47%   -0.85%     
==========================================
  Files          94       95       +1     
  Lines        2171     2190      +19     
  Branches      529      530       +1     
==========================================
- Hits         1874     1872       -2     
- Misses        104      125      +21     
  Partials      193      193              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frett frett merged commit 17ed79e into main Apr 11, 2024
17 of 18 checks passed
@frett frett deleted the kermitCustomLogging branch April 11, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants