Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directly use androidx.annotations now that it supports all our targets #709

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 31, 2024

No description provided.

Copy link

Typescript headers

No changes

See the workflow run

Copy link

iOS Framework headers

  • GodToolsToolParser.h

GodToolsToolParser.h

--- a/Users/runner/work/kotlin-mpp-godtools-tool-parser/kotlin-mpp-godtools-tool-parser/diff/base/GodToolsToolParser.h
+++ b/Users/runner/work/kotlin-mpp-godtools-tool-parser/kotlin-mpp-godtools-tool-parser/diff/head/GodToolsToolParser.h
@@ -462,6 +462,11 @@ __attribute__((swift_name("Accordion.Section")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("AnalyticsEvent")))
 @interface GTTPAnalyticsEvent : GTTPBaseModel
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithParent:(id<GTTPBase>)parent id:(NSString * _Nullable)id action:(NSString *)action trigger:(GTTPAnalyticsEventTrigger *)trigger delay:(int32_t)delay systems:(NSSet<GTTPAnalyticsEventSystem *> *)systems limit:(GTTPInt * _Nullable)limit attributes:(NSDictionary<NSString *, NSString *> *)attributes __attribute__((swift_name("init(parent:id:action:trigger:delay:systems:limit:attributes:)"))) __attribute__((objc_designated_initializer));
 - (BOOL)isForSystemSystem:(GTTPAnalyticsEventSystem *)system __attribute__((swift_name("isForSystem(system:)")));
 - (void)recordTriggeredState:(GTTPState *)state __attribute__((swift_name("recordTriggered(state:)")));
@@ -702,6 +707,11 @@ __attribute__((swift_name("Form")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Gravity")))
 @interface GTTPGravity : GTTPBase
+
+/**
+ * @note annotations
+ *   androidx.annotation.VisibleForTesting
+*/
 - (instancetype)initWithHorizontal:(GTTPGravityHorizontal *)horizontal vertical:(GTTPGravityVertical *)vertical __attribute__((swift_name("init(horizontal:vertical:)"))) __attribute__((objc_designated_initializer));
 @property (class, readonly, getter=companion) GTTPGravityCompanion *companion __attribute__((swift_name("companion")));
 @property (readonly) GTTPGravityHorizontal *horizontal __attribute__((swift_name("horizontal")));
@@ -761,6 +771,11 @@ __attribute__((swift_name("HasPages")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Image")))
 @interface GTTPImage : GTTPContent <GTTPClickable>
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithParent:(id<GTTPBase>)parent resource:(NSString * _Nullable)resource gravity:(GTTPGravityHorizontal *)gravity width:(GTTPDimension *)width events:(NSArray<GTTPEventId *> *)events url:(NSURL * _Nullable)url invisibleIf:(NSString * _Nullable)invisibleIf goneIf:(NSString * _Nullable)goneIf __attribute__((swift_name("init(parent:resource:gravity:width:events:url:invisibleIf:goneIf:)"))) __attribute__((objc_designated_initializer));
 - (BOOL)isEqual:(id _Nullable)other __attribute__((swift_name("isEqual(_:)")));
 - (NSUInteger)hash __attribute__((swift_name("hash()")));
@@ -845,6 +860,11 @@ __attribute__((swift_name("Link")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Manifest")))
 @interface GTTPManifest : GTTPBaseModel <GTTPStyles, GTTPHasPages>
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithConfig:(GTTPParserConfig *)config type:(GTTPManifestType *)type code:(NSString * _Nullable)code locale:(NSLocale * _Nullable)locale primaryColor:(UIColor *)primaryColor primaryTextColor:(UIColor *)primaryTextColor navBarColor:(UIColor * _Nullable)navBarColor navBarControlColor:(UIColor * _Nullable)navBarControlColor backgroundColor:(UIColor *)backgroundColor cardBackgroundColor:(UIColor * _Nullable)cardBackgroundColor categoryLabelColor:(UIColor * _Nullable)categoryLabelColor pageControlColor:(UIColor *)pageControlColor multiselectOptionBackgroundColor:(UIColor * _Nullable)multiselectOptionBackgroundColor multiselectOptionSelectedColor:(UIColor * _Nullable)multiselectOptionSelectedColor textColor:(UIColor *)textColor textScale:(double)textScale resources:(NSArray<GTTPResource *> *(^ _Nullable)(GTTPManifest *))resources shareables:(NSArray<GTTPShareable *> *(^ _Nullable)(GTTPManifest *))shareables tips:(NSArray<GTTPTip *> *(^ _Nullable)(GTTPManifest *))tips pages:(NSArray<GTTPPage *> *(^ _Nullable)(GTTPManifest *))pages pageXmlFiles:(NSArray<GTTPManifestXmlFile *> *)pageXmlFiles __attribute__((swift_name("init(config:type:code:locale:primaryColor:primaryTextColor:navBarColor:navBarControlColor:backgroundColor:cardBackgroundColor:categoryLabelColor:pageControlColor:multiselectOptionBackgroundColor:multiselectOptionSelectedColor:textColor:textScale:resources:shareables:tips:pages:pageXmlFiles:)"))) __attribute__((objc_designated_initializer));
 - (GTTPCategory * _Nullable)findCategoryCategory:(NSString * _Nullable)category __attribute__((swift_name("findCategory(category:)")));
 - (GTTPShareable * _Nullable)findShareableId:(NSString * _Nullable)id __attribute__((swift_name("findShareable(id:)")));
@@ -935,6 +955,11 @@ __attribute__((swift_name("Multiselect.OptionStyle")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Paragraph")))
 @interface GTTPParagraph : GTTPContent <GTTPParent>
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithParent:(id<GTTPBase>)parent content:(NSArray<GTTPContent *> *(^)(GTTPParagraph *))content __attribute__((swift_name("init(parent:content:)"))) __attribute__((objc_designated_initializer));
 @property (readonly) NSArray<GTTPContent *> *content __attribute__((swift_name("content")));
 @property (readonly) NSArray<GTTPTip *> *tips __attribute__((swift_name("tips")));
@@ -952,6 +977,11 @@ __attribute__((swift_name("Resource")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Spacer")))
 @interface GTTPSpacer : GTTPContent
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithParent:(id<GTTPBase>)parent mode:(GTTPSpacerMode *)mode height:(int32_t)height __attribute__((swift_name("init(parent:mode:height:)"))) __attribute__((objc_designated_initializer));
 @property (readonly) int32_t height __attribute__((swift_name("height")));
 @property (readonly) GTTPSpacerMode *mode __attribute__((swift_name("mode")));
@@ -998,6 +1028,11 @@ __attribute__((swift_name("Tabs.Tab")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Text")))
 @interface GTTPText : GTTPContent
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithParent:(id<GTTPBase>)parent text:(NSString *)text textScale:(double)textScale textColor:(UIColor * _Nullable)textColor textAlign:(GTTPTextAlign * _Nullable)textAlign textStyles:(NSSet<GTTPTextStyle *> *)textStyles minimumLines:(int32_t)minimumLines startImage:(NSString * _Nullable)startImage startImageSize:(int32_t)startImageSize endImage:(NSString * _Nullable)endImage endImageSize:(int32_t)endImageSize invisibleIf:(NSString * _Nullable)invisibleIf goneIf:(NSString * _Nullable)goneIf __attribute__((swift_name("init(parent:text:textScale:textColor:textAlign:textStyles:minimumLines:startImage:startImageSize:endImage:endImageSize:invisibleIf:goneIf:)"))) __attribute__((objc_designated_initializer));
 - (BOOL)isEqual:(id _Nullable)other __attribute__((swift_name("isEqual(_:)")));
 - (NSUInteger)hash __attribute__((swift_name("hash()")));
@@ -1146,6 +1181,11 @@ __attribute__((swift_name("ShareableImage")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("InlineTip")))
 @interface GTTPInlineTip : GTTPContent
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithParent:(id<GTTPBase>)parent id:(NSString * _Nullable)id __attribute__((swift_name("init(parent:id:)"))) __attribute__((objc_designated_initializer));
 @property (readonly) NSString * _Nullable id __attribute__((swift_name("id")));
 @property (readonly) GTTPTip * _Nullable tip __attribute__((swift_name("tip")));
@@ -1155,6 +1195,11 @@ __attribute__((swift_name("InlineTip")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Tip")))
 @interface GTTPTip : GTTPBaseModel <GTTPStyles>
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithManifest:(GTTPManifest * _Nullable)manifest id:(NSString *)id type:(GTTPTipType *)type __attribute__((swift_name("init(manifest:id:type:)"))) __attribute__((objc_designated_initializer));
 @property (readonly) NSString *id __attribute__((swift_name("id")));
 @property (readonly) NSArray<GTTPTipPage *> *pages __attribute__((swift_name("pages")));
@@ -1190,6 +1235,11 @@ __attribute__((swift_name("TipPage")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("CallToAction")))
 @interface GTTPCallToAction : GTTPBaseModel
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithPage:(GTTPTractPage *)page label:(GTTPText *(^ _Nullable)(GTTPCallToAction *))label controlColor:(UIColor * _Nullable)controlColor tip:(NSString * _Nullable)tip __attribute__((swift_name("init(page:label:controlColor:tip:)"))) __attribute__((objc_designated_initializer));
 @property (readonly) GTTPText * _Nullable label __attribute__((swift_name("label")));
 @property (readonly) GTTPTip * _Nullable tip __attribute__((swift_name("tip")));
@@ -1207,6 +1257,11 @@ __attribute__((swift_name("Header")))
 __attribute__((objc_subclassing_restricted))
 __attribute__((swift_name("Hero")))
 @interface GTTPHero : GTTPBaseModel <GTTPParent, GTTPHasAnalyticsEvents>
+
+/**
+ * @note annotations
+ *   androidx.annotation.RestrictTo(value=[Scope.TESTS])
+*/
 - (instancetype)initWithPage:(GTTPTractPage *)page analyticsEvents:(NSArray<GTTPAnalyticsEvent *> *)analyticsEvents heading:(GTTPText * _Nullable (^ _Nullable)(id<GTTPBase>))heading __attribute__((swift_name("init(page:analyticsEvents:heading:)"))) __attribute__((objc_designated_initializer));
 - (NSArray<GTTPAnalyticsEv

See the full diff from https://github.com/CruGlobal/kotlin-mpp-godtools-tool-parser/actions/runs/11616325561

See the workflow run

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (555ff41) to head (e7cad81).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   86.01%   85.92%   -0.09%     
==========================================
  Files          95       95              
  Lines        2331     2331              
  Branches      550      550              
==========================================
- Hits         2005     2003       -2     
- Misses        126      128       +2     
  Partials      200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frett frett merged commit a2441ef into main Oct 31, 2024
19 checks passed
@frett frett deleted the removeGtoSupportAnnotations branch October 31, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant