-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDPX-8385] Preserve previous task name #1169
Conversation
Preview branch generated at https://8385-preserve-previous-task-name.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 975d3ae No significant changes found |
src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this!! The code looks good. I know you and others have been after this for some time. This works for when you're on the partner care phase, but when you're on another phase, it doesn't.
Maybe this is working as expected, and I'm testing it wrong. This is what I have found in my testing:
task-name.mov
src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx
Outdated
Show resolved
Hide resolved
ae31336
to
91c491d
Compare
@dr-bizz I followed your exact steps, and I think it should work now that I'm taking a different approach for deciding whether to use the previous task name. Thanks for taking the time to test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Great work. It was a little hard to review since you did a force push, so I wasn't sure what I reviewed already, but the code looks great.
dceb34f
to
8b8c90e
Compare
Description
If the user had a customized task name for a text message task, for example, and they make the next action a phone call, we just use the autogenerated task name. This is to prevent someone who didn't customize their task name from getting "Call to Initiate Appointment" as the initial task name for a text message task. I think this is a reasonable tradeoff, but feel free to discuss.EDIT: Now I'm just comparing the task subject with the default task subject. If they differ, this means that the user customized the task subject. This logic will break if the server changes the default task subjects, but this should be rare, so I think this is acceptable.Testing
MPDX-8385
Checklist: