Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPDX-8416] Turn article name into a link that opens in a new tab #1178

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[MPDX-8416] Turn article name into a link that opens in a new tab #1178

merged 1 commit into from
Nov 7, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 5, 2024

Description

In the Helpjuice beacon, make the article header a link that opens the article in a new tab on Helpjuice.

Testing

  • Search for an article and click on it or click on a suggested article
  • Verify that the article header is a link that opens the article in a new tab
Screenshot 2024-11-05 at 3 13 09 PM

MPDX-8416

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Nov 5, 2024
@canac canac requested a review from dr-bizz November 5, 2024 21:13
@canac canac self-assigned this Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Preview branch generated at https://8416-beacon-new-tab.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 01d172b

No significant changes found

dr-bizz
dr-bizz reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this!

src/components/Helpjuice/Helpjuice.test.tsx Outdated Show resolved Hide resolved
@canac canac requested a review from dr-bizz November 6, 2024 16:05
@canac canac enabled auto-merge November 7, 2024 21:02
@canac canac merged commit 62fca45 into main Nov 7, 2024
18 checks passed
@canac canac deleted the 8416-beacon-new-tab branch November 7, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz