Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-Jira] Remove storybook and chromatic #1181

Merged
merged 5 commits into from
Nov 11, 2024
Merged

[no-Jira] Remove storybook and chromatic #1181

merged 5 commits into from
Nov 11, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 11, 2024

Description

Remove storybook and chromatic. We are not using them, and keeping them adds a maintenance burden of upgrading to the latest version and updating the story files.

This will also resolve some dependabot warnings from webpack v4.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac
Remove storybook and chromatic
88b3f31 
We are not using it, and keeping it adds a maintenance burden of
upgrading to the latest version and updating the story files.
@canac canac requested a review from dr-bizz November 11, 2024 16:43
@canac canac self-assigned this Nov 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 5643e76

No significant changes found

@canac canac mentioned this pull request Nov 11, 2024
Closed
dr-bizz
dr-bizz approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing storybook

pages/accountLists/[accountListId]/contacts/[[...contactId]].stories.tsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you meant to get rid of this component? I don't think it's used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did. There are no *.stories.* files in the repo anymore.

@dr-bizz
Copy link
Contributor

dr-bizz commented Nov 11, 2024

Let's merge it with staging or put it on a feature branch before merging it into main, just in case. I don't need to test it, if you just check it, that is fine.

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Nov 11, 2024
@github-actions GitHub Actions
Copy link

Preview branch generated at https://remove-storybook.d3dytjb8adxkk5.amplifyapp.com

@canac canac merged commit a601a01 into main Nov 11, 2024
18 checks passed
@canac canac deleted the remove-storybook branch November 11, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz