Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8358 Use API translations for Task Activity and Display Result #1192

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8358&sprint=1288#

  • Use API translated constants for Activites and DisplayResults
  • Use activityTypes() map from usePhaseData()
  • Update tests and mocks

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Nov 12, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Nov 12, 2024
Copy link

Preview branch generated at https://MPDX-8358-task-action-result.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks for the attention to detail to update the mocks too!

Copy link

Bundle sizes [mpdx-react]

Compared against 9036e71

Dynamic import Size (gzipped) Diff
../src/components/Task/MassActions/EditTasks/DynamicMassActionsEditTasksModal.tsx -> ./MassActionsEditTasksModal 97.54 KB -1.06 KB
../src/components/Task/Modal/Form/DynamicTaskModalForm.tsx -> ./TaskModalForm 117.86 KB -1.45 KB
../src/components/Task/Modal/Form/LogForm/DynamicTaskModalLogForm.tsx -> ./TaskModalLogForm 148.52 KB -1.47 KB

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The bundle size went down a little bit too! 🎉

src/hooks/usePhaseData.ts Outdated Show resolved Hide resolved
@caleballdrin caleballdrin merged commit 0e15c85 into main Nov 12, 2024
17 of 18 checks passed
@caleballdrin caleballdrin deleted the MPDX-8358-task-action-result branch November 12, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants