Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming to use pgAdmin CR instance UID #3756

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Update naming to use pgAdmin CR instance UID #3756

merged 1 commit into from
Oct 19, 2023

Conversation

tjmoore4
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Update all relevant names and impacted tests.

Other Information:
Issue: PGO-591

@tjmoore4
Update naming to use pgAdmin CR instance UID
58c51a4 
Update all relevant names and impacted tests.

Issue: PGO-591
jmckulk
jmckulk approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@jmckulk jmckulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

internal/controller/standalone_pgadmin/pod_test.go
@@ -70,7 +70,7 @@ containers:
valueFrom:
secretKeyRef:
key: password
name: pgadmin-standalone-pgadmin
name: pgadmin-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume since the cr doesn't really exist, the UID is just an empty string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. I think that's ok for these tests.

benjaminjb
benjaminjb approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the KUTTL test is working locally for you now?

@tjmoore4
Copy link
Contributor Author

I assume the KUTTL test is working locally for you now?

Yep, working as expected.

@tjmoore4 tjmoore4 merged commit f6b9f11 into CrunchyData:master Oct 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmckulk jmckulk jmckulk approved these changes

@benjaminjb benjaminjb benjaminjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjmoore4 @benjaminjb @jmckulk