Skip to content

Commit

Permalink
bug-fixes, add NotSupportedRegionError
Browse files Browse the repository at this point in the history
  • Loading branch information
PseudoElement committed Jul 24, 2024
1 parent 71c2cf2 commit bc7c0a6
Show file tree
Hide file tree
Showing 7 changed files with 29 additions and 23 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rubic-sdk",
"version": "5.32.5",
"version": "5.32.5-alpha.rango.3",
"description": "Simplify dApp creation",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
11 changes: 11 additions & 0 deletions src/common/errors/swap/not-supported-region.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { RubicSdkError } from 'src/common/errors/rubic-sdk.error';

/**
* Thrown, when provider does not support region.
*/
export class NotSupportedRegionError extends RubicSdkError {
constructor() {
super();
Object.setPrototypeOf(this, NotSupportedRegionError.prototype);
}
}
12 changes: 0 additions & 12 deletions src/features/common/constants/bridge-to-onchain.ts

This file was deleted.

13 changes: 10 additions & 3 deletions src/features/common/providers/rango/utils/rango-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ import {
} from 'src/core/blockchain/web3-public-service/web3-public/models/tx-status';
import { CROSS_CHAIN_TRADE_TYPE } from 'src/features/cross-chain/calculation-manager/models/cross-chain-trade-type';
import { BridgeType } from 'src/features/cross-chain/calculation-manager/providers/common/models/bridge-type';
import { OnChainTradeType } from 'src/features/on-chain/calculation-manager/providers/common/models/on-chain-trade-type';
import {
ON_CHAIN_TRADE_TYPE,
OnChainTradeType
} from 'src/features/on-chain/calculation-manager/providers/common/models/on-chain-trade-type';

import { rangoApiBlockchainNames, RangoBlockchainName } from '../models/rango-api-blockchain-names';
import { RANGO_SWAP_STATUS, RangoSwapStatus } from '../models/rango-api-status-types';
Expand Down Expand Up @@ -63,8 +66,12 @@ export class RangoUtils {
}

public static getTradeTypeForRubic(
rangoTradeType: RangoTradeType
rangoTradeType: RangoTradeType,
type: 'cross-chain' | 'on-chain'
): BridgeType | OnChainTradeType {
return RANGO_TO_RUBIC_PROVIDERS[rangoTradeType] || CROSS_CHAIN_TRADE_TYPE.RANGO;
if (type === 'cross-chain') {
return RANGO_TO_RUBIC_PROVIDERS[rangoTradeType] || CROSS_CHAIN_TRADE_TYPE.RANGO;
}
return RANGO_TO_RUBIC_PROVIDERS[rangoTradeType] || ON_CHAIN_TRADE_TYPE.RANGO;
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import BigNumber from 'bignumber.js';
import { NotSupportedTokensError, RubicSdkError } from 'src/common/errors';
import { NotSupportedTokensError } from 'src/common/errors';
import { NotSupportedRegionError } from 'src/common/errors/swap/not-supported-region';
import { PriceTokenAmount } from 'src/common/tokens';
import { BLOCKCHAIN_NAME } from 'src/core/blockchain/models/blockchain-name';
import { BlockchainsInfo } from 'src/core/blockchain/utils/blockchains-info/blockchains-info';
Expand Down Expand Up @@ -71,7 +72,7 @@ export async function getProxyMethodArgumentsAndTransactionData<
swapRequest
);
if (swapData.resCode === 1146) {
throw new RubicSdkError('[BridgersApiError] Your region is not supported!');
throw new NotSupportedRegionError();
}
if (!swapData.data?.txData) {
throw new NotSupportedTokensError();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ export class RangoCrossChainProvider extends CrossChainProvider {
const type = rangoPath.swapperType === 'DEX' ? 'on-chain' : 'cross-chain';

const provider = RangoUtils.getTradeTypeForRubic(
rangoPath.swapper.swapperGroup as RangoTradeType
rangoPath.swapper.swapperGroup as RangoTradeType,
type
);

const fromBlockchain = RangoUtils.getRubicBlockchainByRangoBlockchain(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,7 @@ export class XyCrossChainProvider extends CrossChainProvider {
if (transitFromAddress) {
routePath.push({
type: 'on-chain',
// @TODO provider: ON_CHAIN_TRADE_TYPE.XY_DEX,
provider: ON_CHAIN_TRADE_TYPE.ONE_INCH,
provider: ON_CHAIN_TRADE_TYPE.XY_DEX,
path: [fromToken, fromTokenAmount]
});
}
Expand All @@ -234,8 +233,7 @@ export class XyCrossChainProvider extends CrossChainProvider {
if (transitToAddress) {
routePath.push({
type: 'on-chain',
// @TODO provider: ON_CHAIN_TRADE_TYPE.XY_DEX,
provider: ON_CHAIN_TRADE_TYPE.ONE_INCH,
provider: ON_CHAIN_TRADE_TYPE.XY_DEX,
path: [toTokenAmount, toToken]
});
}
Expand Down

0 comments on commit bc7c0a6

Please sign in to comment.