This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Pull Request for Varga Vajk #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster442
reviewed
May 1, 2022
|
|
||
| public BookManager(List<Book> books) | ||
| { | ||
| Books = books.Distinct().ToList(); |
There was a problem hiding this comment.
HashSet is lehetne éppen, akkor a Distinct és a ToList megspórolható, illetve későbbi bővítésnél is Distinct maradna.
| { | ||
| internal record Book | ||
| { | ||
| public Guid Id { get; set; } |
There was a problem hiding this comment.
Az ID-t biztos állítani kell létrehozás után is ?
| { | ||
| internal static class FileReader | ||
| { | ||
| public static List<Book> ReadAllBooks() |
There was a problem hiding this comment.
Ezt a metódust pl több kisebbre lehetne bontani szerintem.
|
|
||
| namespace Library.Serializer | ||
| { | ||
| internal class CustomDateJsonConverter : JsonConverter<DateTime> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.