-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFAM77 #24
base: main
Are you sure you want to change the base?
BFAM77 #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Szép munka, de azért a Program.cs-t lehetett volna feldarabolni több osztályra...
|
||
namespace BFAM77 | ||
{ | ||
public class FilmWithAvailability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hunglish. Vagy angol legyen teljesen vagy magyar, de inkább angol akkor már a kód...
{ | ||
Console.Write("Biztos üresen akarja hagyni? (igen/nem): "); | ||
var confirm = Console.ReadLine(); | ||
if (confirm.Equals("igen", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
public Film KolcsonzottFilm { get; set; } | ||
public DateTime KolcsonzesDatuma { get; set; } | ||
public DateTime Hatarido { get; set; } | ||
public bool Lezarult { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha a konstruktor állít mindent, akkor miért settelhető kívülről?
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha 700+ sor a Program.cs, akkor az biztos, hogy lehetett volna kisebb részekre vágni...
public class InputHelperTests | ||
{ | ||
[Fact] | ||
public void GetStringInput_ReturnsInput() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tesztek 👍
No description provided.