Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFAM77 #24

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

BFAM77 #24

wants to merge 7 commits into from

Conversation

sanyopapa
Copy link

No description provided.

Copy link
Contributor

@webmaster442 webmaster442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Szép munka, de azért a Program.cs-t lehetett volna feldarabolni több osztályra...


namespace BFAM77
{
public class FilmWithAvailability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hunglish. Vagy angol legyen teljesen vagy magyar, de inkább angol akkor már a kód...

{
Console.Write("Biztos üresen akarja hagyni? (igen/nem): ");
var confirm = Console.ReadLine();
if (confirm.Equals("igen", StringComparison.OrdinalIgnoreCase))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

public Film KolcsonzottFilm { get; set; }
public DateTime KolcsonzesDatuma { get; set; }
public DateTime Hatarido { get; set; }
public bool Lezarult { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha a konstruktor állít mindent, akkor miért settelhető kívülről?

}
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha 700+ sor a Program.cs, akkor az biztos, hogy lehetett volna kisebb részekre vágni...

public class InputHelperTests
{
[Fact]
public void GetStringInput_ReturnsInput()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesztek 👍

@webmaster442 webmaster442 linked an issue Dec 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BFAM77-Videotéka
2 participants