F1H43C - EEJYN9 Torpedó konzolos játék #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ship placing logic
Implemented game logic and added gameplay
Added Statistics
Preferences
Added unit tests
Implemented tests for the preferences and Changed some file names
webmaster442
reviewed
Dec 5, 2024
| private IPlayer HumanPlayer; | ||
| private IPlayer AIPlayer; | ||
|
|
||
| public static GameManager Instance |
| if (string.IsNullOrWhiteSpace(username)) | ||
| throw new ArgumentException("Username cannot be empty", nameof(username)); | ||
|
|
||
| ValidateAndApplyDefaults(preferences); |
| } | ||
|
|
||
| public void ValidateAndApplyDefaults(GamePreferences preferences) | ||
| { |
There was a problem hiding this comment.
Mivel ez JSON akár egy JSON Schema alapú validációval is megoldható lenne. Egyetlen baj, hogy a .NET beépített megoldást még nem tartalmaz JSON Schema olvasására.
| - A kiszámolt statisztikákat elmentjük és megjelenítjük a konzolon | ||
|
|
||
|
|
||
| ### Játék indítása |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torpedó konzolos játék
Issue