upload #41
Open
upload #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster442
reviewed
Dec 9, 2024
| } | ||
|
|
||
|
|
||
| public Polinom Clone() |
There was a problem hiding this comment.
Ez egy DeepClone implementáció, amit jó lenne ha a metódus neve jelezne.
| { | ||
| while (Numbers.Count > 0 && Numbers[0] == 0) | ||
| { | ||
| Numbers.RemoveAt(0); |
There was a problem hiding this comment.
Lista elejéről törlés piszok költséges. Stack esetleg? vagy Láncolt lista a sima lista helyett?
| { | ||
| if (obj is Polinom other) | ||
| { | ||
| RemoveLeadingZeros(); |
There was a problem hiding this comment.
Öö :D Az Equals módosítja az objektum belső állapotát a RemoveLeadingZeros() hívással?? Ennek nem így kellene működnie. Ha a RemoveLeadingZeros() szükséges, akkor azt miért nem a létrehozáskor hívod? Az Equals hívásnak NEM szabad módosítania belső állapotot. Ez nagyon durva Single responsibility és Liskov elv sértés is.
| { | ||
| expression = Regex.Replace(expression, @"\s*([+\-*/%,()])\s*", "$1"); | ||
|
|
||
| if (polynomials.ContainsKey(expression)) |
There was a problem hiding this comment.
Ezt bőven szét lehetetett volna szedni egy külön osztályra.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.