Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datapoints-graph) Bumped package versions in order to fix missing asset selector icons. #21

Merged

Conversation

eniosultan
Copy link
Collaborator

@eniosultan eniosultan commented Nov 17, 2023

Issue

The data points graph 2.0 was using different instance of ngx-components which caused issues with the asset selector. The issue was fixed at some point and in order to fix it here we need to bump the version of the package.

Proposed changes

Bump @c8y/ngx-components, @c8y/cli, @c8y/styles @c8y/client versions

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@eniosultan eniosultan requested a review from jdre-c8y November 17, 2023 12:55
package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@eniosultan eniosultan changed the title bumped c8y/client ngx-components and styles version to latest published fix(datapoints-graph) Bumped package versions in order to fix missing asset selector icons. Nov 17, 2023
@eniosultan eniosultan requested a review from jdre-c8y November 17, 2023 15:12
@eniosultan eniosultan requested a review from reey November 17, 2023 15:36
@jdre-c8y
Copy link
Collaborator

please also add a little bit more description in PR description- what was exact issue, what was causing it (not sharing ngx-components between plugin and shell). In 1 month we will forget what was the issue and this repo has no link with our internal JIRA

@eniosultan
Copy link
Collaborator Author

please also add a little bit more description in PR description- what was exact issue, what was causing it (not sharing ngx-components between plugin and shell). In 1 month we will forget what was the issue and this repo has no link with our internal JIRA

done

@eniosultan eniosultan merged commit 6e1ee6b into main Nov 27, 2023
1 check passed
@eniosultan eniosultan deleted the bugfix/c8y-version-bump-to-fix-asset-selelctor-icon-issues branch November 27, 2023 09:19
@eniosultan eniosultan added the bug Something isn't working label Nov 27, 2023
@eniosultan eniosultan restored the bugfix/c8y-version-bump-to-fix-asset-selelctor-icon-issues branch November 27, 2023 11:47
@eniosultan eniosultan deleted the bugfix/c8y-version-bump-to-fix-asset-selelctor-icon-issues branch November 27, 2023 11:47
@eniosultan eniosultan restored the bugfix/c8y-version-bump-to-fix-asset-selelctor-icon-issues branch November 27, 2023 11:51
@eniosultan eniosultan deleted the bugfix/c8y-version-bump-to-fix-asset-selelctor-icon-issues branch November 27, 2023 11:53
@eniosultan eniosultan restored the bugfix/c8y-version-bump-to-fix-asset-selelctor-icon-issues branch November 27, 2023 12:58
@eniosultan eniosultan deleted the bugfix/c8y-version-bump-to-fix-asset-selelctor-icon-issues branch November 27, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants