Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Web SDK): [no-issue] Further improvements and fixes #48

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(Web SDK): [no-issue] Further improvements and fixes #48

wants to merge 10 commits into from

Conversation

eniosultan
Copy link
Collaborator

@eniosultan eniosultan commented Sep 30, 2024 •
edited
Loading

Proposed changes

Fixeds/Improvements:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Base automatically changed from feature/dpg-fixes-and-improvements to main November 8, 2024 14:16
@eniosultan eniosultan requested a review from janhommes November 12, 2024 14:21
jdre-c8y
jdre-c8y reviewed Nov 13, 2024
View reviewed changes
src/app/datapoints-graph/charts/y-axis.service.ts Outdated Show resolved Hide resolved
src/app/datapoints-graph/datapoints-graph-config/datapoints-graph-widget-config.component.html
Comment on lines +44 to +47
<label
[title]="'Enable date selection in the widget view.' | translate"
class="c8y-checkbox"
>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lack of this checkbox was UX decision by Carlos. more at #32 (comment)
should be discussed I guess

@eniosultan @jdre-c8y
Update src/app/datapoints-graph/charts/y-axis.service.ts
c2e84f6 
Co-authored-by: Jakub Drewniak <[email protected]>
Signed-off-by: Enio Sultan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdre-c8y jdre-c8y jdre-c8y left review comments

@janhommes janhommes Awaiting requested review from janhommes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniosultan @janhommes @jdre-c8y