Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datapoints-graph): [no-issue] Add possibility to match datapoints to alarms or events #50

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

eniosultan
Copy link
Collaborator

@eniosultan eniosultan commented Oct 7, 2024

It is now possible to match datapoints to alarms or events.

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@janhommes
Copy link
Collaborator

Hey, having issues to run this:
image

The icon and line is never displayed. Any idea why?

Base automatically changed from feature/dpg-fixes-and-improvements to main November 8, 2024 14:16
@eniosultan
Copy link
Collaborator Author

Hey, having issues to run this: image

The icon and line is never displayed. Any idea why?

hmm I guess since we merged a lot of other PR's with improvements, fixes and even refactoring, they might have broken this one, I'll have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants